fix(ui): remove iOS fixed-shell bottom gap by BigSimmo · Pull Request #1266 · BigSimmo/Database

BigSimmo · 2026-07-26T18:34:58Z

Summary

Replace both viewport-sized fixed phone application roots with one bounded, in-flow dynamic-viewport shell.
Preserve the zero hidden-composer reserve while ensuring live content owns the final viewport pixel.
Add static and production-browser guards for the physical-iOS fixed-container gap and viewport-resize scroll stability.

RAG impact: no retrieval behaviour change — phone viewport shell and UI regression coverage only.

Verification

npm run verify:pr-local — PASS: formatting, lint, typecheck, 3,519 tests, production build, client-secret scan, and 36 offline RAG fixtures.
npm run verify:ui — PASS: 314/314 Chromium UI tests across all phone modes.
Focused production WebKit — PASS: Therapy hidden-edge/viewport-resize regression and dashboard bottom-stability route.
npm run verify:cheap — PASS: 393 test files; 3,519 passed / 2 skipped.
npm run verify:release — not run because its live/provider-governance lanes are outside this UI-only change; no OpenAI, Supabase, or Railway API checks were invoked.

Risk and rollout

Risk: Low-to-moderate UI geometry change. Highest residual risk is physical-device iOS compositor behaviour beyond desktop WebKit emulation.
Rollback: Revert product commit a8efe4a08; retain the append-only review ledger as historical evidence and append a correction if needed.
Provider or production effects: Merging to main triggers the repository-configured Railway production auto-deploy. No separate provider mutation is performed.

Clinical Governance Preflight

Not applicable: this change does not touch ingestion, answer generation, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output.

Notes

Release review: APPROVE with no P0-P3 findings.
Root cause is the physical-iOS viewport-sized fixed-container paint path; prior dock geometry and reserve assertions were correct but could not observe the OS compositor gap.

Summary by CodeRabbit

Bug Fixes
- Improved iOS phone viewport rendering to prevent blank gaps/clipped bottom content.
- Kept shared phone shells in normal flow so main content remains the in-flow scroll area.
- Refined search scroll hide/reveal behavior on phones and stabilized calculator sheet open/close focus handling.
Tests
- Added and strengthened UI/guard tests for phone shell class usage, bottom-edge paint ownership, viewport resize behavior, microtask-based dock focus reset, and hydrated global search input readiness.

supabase · 2026-07-26T18:35:05Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

coderabbitai · 2026-07-26T18:35:24Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d696ecc-7333-437d-b3c8-76c025e65ec9

📥 Commits

Reviewing files that changed from the base of the PR and between e48873e and af8883d.

📒 Files selected for processing (6)

docs/branch-review-ledger.md
src/app/globals.css
src/components/calculators/search-page.tsx
tests/mobile-chrome-paint-contract.test.ts
tests/ui-phone-scroll.spec.ts
tests/ui-tools.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

src/app/globals.css

📝 Walkthrough

Walkthrough

Phone dashboard and search shells now remain in normal flow on small screens, use phone-scoped viewport sizing, and include fixes and tests for bottom-edge painting, calculator focus reset timing, and hydrated search input handling.

Changes

Phone viewport and interaction contracts

Layer / File(s)	Summary
In-flow phone shell contract `docs/search-chrome-behaviour.md`, `src/app/globals.css`, `src/components/ClinicalDashboard.tsx`, `src/components/clinical-dashboard/global-search-shell.tsx`, `src/components/clinical-dashboard/use-hide-on-scroll.ts`	Phone shells no longer use fixed inset positioning; shared CSS applies phone-only `vh`, `svh`, and `dvh` sizing, while the scroll-hide contract is documented for in-flow scrolling.
Bottom-edge rendering validation `tests/clinical-dashboard-merge-artifacts.test.ts`, `tests/ui-phone-scroll.spec.ts`, `docs/branch-review-ledger.md`	Static and UI checks verify shell positioning, bottom-pixel ownership, viewport alignment, resize scroll preservation, and recorded verification results.
Calculator and search interaction synchronization `src/components/calculators/search-page.tsx`, `tests/mobile-chrome-paint-contract.test.ts`, `tests/ui-tools.spec.ts`	Calculator dock focus clearing uses a queued microtask, while shared search tests wait for React `onChange` hydration and verify accepted input values.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

BigSimmo/Database#1264: Directly overlaps the calculator dock reserve and focus lifecycle contract.
BigSimmo/Database#1187: Updates the same in-flow phone shell and scroll-hide contract.
BigSimmo/Database#1246: Modifies related phone chrome and viewport-edge paint-contract tests.

Suggested labels: codex

Suggested reviewers: cursoragent

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: removing the iOS fixed-shell bottom gap.
Description check	✅ Passed	The description follows the repository template and includes summary, verification, risk, governance, and notes with relevant details.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/phone-bottom-band-root-20260727

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/branch-review-ledger.md`:
- Line 1109: Update the review-ledger entry dated 2026-07-27 to use the actual
completion date, or remove/defer the row until the review has occurred; do not
record a future release review.

In `@src/app/globals.css`:
- Around line 2345-2348: Remove the duplicate min-height and height declarations
in the affected global stylesheet rule. Keep the 100vh values as defaults and
move the 100svh overrides into a dedicated `@supports` block, following the
existing 100dvh pattern.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dff3d251-c181-4e26-8c89-1774db93d17b

📥 Commits

Reviewing files that changed from the base of the PR and between cc1abfe and e48873e.

📒 Files selected for processing (8)

docs/branch-review-ledger.md
docs/search-chrome-behaviour.md
src/app/globals.css
src/components/ClinicalDashboard.tsx
src/components/clinical-dashboard/global-search-shell.tsx
src/components/clinical-dashboard/use-hide-on-scroll.ts
tests/clinical-dashboard-merge-artifacts.test.ts
tests/ui-phone-scroll.spec.ts

github-actions · 2026-07-26T18:46:56Z

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #5899 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

BigSimmo added 2 commits July 27, 2026 02:32

fix(ui): remove iOS fixed-shell bottom gap

a8efe4a

docs: record phone shell release review

e48873e

coderabbitai Bot reviewed Jul 26, 2026

View reviewed changes

Comment thread docs/branch-review-ledger.md

Comment thread src/app/globals.css Outdated

BigSimmo added 6 commits July 27, 2026 03:11

fix(ui): stabilize calculator dock hide lifecycle

a8a72a4

docs: record calculator dock CI follow-up

a3ffd11

fix(test): wait for tools search hydration

cc63ee9

docs: record tools search CI follow-up

1a0e465

fix(ui): separate phone viewport fallbacks

a4802b9

docs: record viewport fallback review

af8883d

BigSimmo merged commit a3420d0 into main Jul 26, 2026
43 checks passed

BigSimmo deleted the codex/phone-bottom-band-root-20260727 branch July 26, 2026 20:00

coderabbitai Bot mentioned this pull request Jul 27, 2026

fix(ui): restore phone Safari and PWA edge chrome #1270

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ui): remove iOS fixed-shell bottom gap - #1266

fix(ui): remove iOS fixed-shell bottom gap#1266
BigSimmo merged 8 commits into
mainfrom
codex/phone-bottom-band-root-20260727

BigSimmo commented Jul 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

supabase Bot commented Jul 26, 2026

Uh oh!

coderabbitai Bot commented Jul 26, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BigSimmo commented Jul 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Risk and rollout

Clinical Governance Preflight

Notes

Summary by CodeRabbit

Uh oh!

supabase Bot commented Jul 26, 2026

Uh oh!

coderabbitai Bot commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026

CI triage

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BigSimmo commented Jul 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 26, 2026 •

edited

Loading